Merged
Conversation
rwjblue
reviewed
Apr 6, 2018
| "devDependencies": { | ||
| "broccoli-asset-rev": "^2.4.5", | ||
| "broccoli-babel-transpiler": "~5.6.1", | ||
| "broccoli-babel-transpiler": "~5.6.2", |
Member
There was a problem hiding this comment.
It is slightly odd to leave this at 5.x, but it seems totally fine to update in a follow-up...
| depScriptTags += ` | ||
| <script type="text/javascript"> | ||
| Object.keys(requirejs.entries).forEach(function (moduleName) { | ||
| require(moduleName).__esModule = true; |
Member
There was a problem hiding this comment.
Hmm, I don't think you should need to do this...
Contributor
Author
There was a problem hiding this comment.
Added comment explaining
| plugins: [ | ||
| ['transform-es2015-modules-amd', { | ||
| loose: true, | ||
| noInterop: false |
Member
There was a problem hiding this comment.
If you set this to true, I do not think that you will need the __esModule = true flag above (because Babel will not check if it has to interop).
Contributor
Author
There was a problem hiding this comment.
Needed for compat with addons compiled with babel@5 using modules: 'amdStrict' Added comment explaining.
Member
|
👏 👏 👏 👏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For issue #593