Implement Unsaved Indicator#95
Conversation
There was a problem hiding this comment.
It seems like this could just be a computed property
|
Wouldn't something like https://github.com/lolmaus/ember-cli-stained-by-children solve this? |
|
@stefanpenner @rwjblue I must be missing something obvious. I can't figure out how to make unsaved a computed property. |
|
@rwjblue @stefanpenner @joostdevries Refactored. Please review again. |
There was a problem hiding this comment.
can we use an action from the template instead of this observer?
There was a problem hiding this comment.
Nope. Not until Ember 2.0. emberjs/ember.js#5433
There was a problem hiding this comment.
Found a solution. We can write our own checkbox component.
|
@joostdevries I wish. I unraveled the observer everyone complained about and ended up with 3. |
|
@stefanpenner @rwjblue Still waiting for a hint as to how all this could have been done with a computed property. |
|
I'm confused why @joostdevries example doesn't work for this case |
|
@stefanpenner I really don't know. I just tried it and it didn't work. |
|
@joostdevries @stefanpenner @rwjblue Observers removed. Contortions added. Please review again. |
There was a problem hiding this comment.
why not just send contentsChanged here?
|
@joostdevries Updated. |
|
👍 |
Implement Unsaved Indicator
4 participants
No description provided.