Merged
Conversation
Contributor
There was a problem hiding this comment.
this.application = ..
Ember.run(this.application)
should help mitigate some leaks :) also the new CLI default.
Member
There was a problem hiding this comment.
@Gaurav0 - To clarify, @stefanpenner is referring to avoiding usage of the var application variable here. Save the created instance on this instead (helps the test framework ensure proper cleanup is done).
Member
|
LOVE THE TESTS!!! THANK YOU!!! |
Contributor
Author
|
@rwjblue @stefanpenner Updated as per your comments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.