Skip to content

Move request package into devDependencies#54

Merged
rwjblue merged 1 commit intoember-fastboot:masterfrom
bobisjan:request-as-dev-dependency
Feb 5, 2020
Merged

Move request package into devDependencies#54
rwjblue merged 1 commit intoember-fastboot:masterfrom
bobisjan:request-as-dev-dependency

Conversation

@bobisjan
Copy link
Copy Markdown
Contributor

@bobisjan bobisjan commented Jan 4, 2020

request is only used for testing via request-promise.

@bobisjan bobisjan force-pushed the request-as-dev-dependency branch from e82916c to 4b21499 Compare January 17, 2020 07:41
@bobisjan bobisjan force-pushed the request-as-dev-dependency branch from 4b21499 to fd3404e Compare January 19, 2020 11:15
@rwjblue rwjblue merged commit b5a4751 into ember-fastboot:master Feb 5, 2020
@rwjblue
Copy link
Copy Markdown
Member

rwjblue commented Feb 5, 2020

Awesome, thank you!

@bobisjan bobisjan deleted the request-as-dev-dependency branch February 5, 2020 21:04
@rwjblue rwjblue added the bug label Oct 16, 2020
@rwjblue rwjblue changed the title Move request into dev dependencies Move request package into devDependencies Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants