Skip to content

Use append to support multi-value headers#60

Merged
rwjblue merged 1 commit intoember-fastboot:masterfrom
bobisjan:response-append
Oct 16, 2020
Merged

Use append to support multi-value headers#60
rwjblue merged 1 commit intoember-fastboot:masterfrom
bobisjan:response-append

Conversation

@bobisjan
Copy link
Copy Markdown
Contributor

@bobisjan bobisjan commented Feb 6, 2020

No description provided.

@bobisjan
Copy link
Copy Markdown
Contributor Author

bobisjan commented Feb 6, 2020

@rwjblue, I would like to add some tests, but not sure how - the fixtures do not have real fastboot service. Should I mock response headers somehow or add ember-cli-fastboot dependency?

@bobisjan bobisjan requested a review from rwjblue February 21, 2020 07:19
@bobisjan
Copy link
Copy Markdown
Contributor Author

@rwjblue, test added, should be ready for review.

@rwjblue rwjblue merged commit 90095a2 into ember-fastboot:master Oct 16, 2020
@rwjblue rwjblue added the bug label Oct 16, 2020
@bobisjan bobisjan mentioned this pull request Oct 20, 2020
@bobisjan bobisjan deleted the response-append branch October 22, 2020 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants