Add support for passing metadata into visitOptions of fastboot visit#66
Merged
rwjblue merged 2 commits intoember-fastboot:masterfrom Nov 20, 2020
Merged
Conversation
rwjblue
requested changes
Aug 28, 2020
Member
rwjblue
left a comment
There was a problem hiding this comment.
In general, this seems fine but I'd prefer to change this a bit so that we grab options.visitOptions instead.
Then we can tweak the thing in the returned function to be something like:
let visitOptions = Object.assign({}, opts.visitOptions, { request: req, response: res });
fastboot
.visit(path, visitOptions)
.then(success, failure);2f605af to
eb983c3
Compare
rwjblue
reviewed
Nov 6, 2020
24ffe13 to
9a9a07d
Compare
rwjblue
approved these changes
Nov 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for passing metadata into visitOptions of fastboot visit
Context:
Currently, with local development of addons that rely on fastboot metadata, there are cases where the metadata is set by another library of the consuming app. Hence, local development of such addons can become challenging. This PR introduces a way to pass in the
metadatathrough the visitOptions, so that the dummy apps could leverage it.Once this change is in, we could potentially pass in the
metadatainto the middleware from here:https://github.com/ember-fastboot/ember-cli-fastboot/blob/master/packages/ember-cli-fastboot/index.js#L339.
Ref: https://github.com/rileyhilliard/fastboot-addon-development
TODO: