Update to fastboot@3.1.0#70
Merged
rwjblue merged 6 commits intoember-fastboot:masterfrom Oct 23, 2020
Merged
Conversation
rwjblue
force-pushed
the
update-fastboot
branch
from
f623014 to
b56547d
Compare
rwjblue
force-pushed
the
update-fastboot
branch
from
d812d90 to
14998ec
Compare
Closed
Contributor
|
I've tried this locally, and it looks that there is difference between
When I moved the result finalisation into |
Member
Author
|
Thank you @bobisjan! |
I find this behavior to be _very odd_, but it matches what we have under test. Specifically, it seems bizarre to call `next` and then do _anything_ with the response still, calling `next` signifies "I'm done here"!!?!?!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.