Removal of View Tab

[nummi]

Place for discussion around removal of the View Tab.

Todo

• Do we need faster access to model?
• Make Components Tab default route
• Display render performance in Components tab?
• Ember.js guides update

Current View Tab Functionality

1. List of components
   • ☑️ covered by Components Tab
2. Template path
   • click to view element in browser Elements panel
   • ☑️ covered by Routes and Components tab
3. Model
   • open in object inspector or send to console
   • 🤷🏽‍♀️ I believe this is the model of the controller which can be accessed from the Routes Tab by selecting a controller and finding the model in the object inspector. This adds more clicks.
4. Controller
   • open in object inspector or send to console
   • ☑️ covered by Routes Tab
5. Render times
   • ☑️ covered by Performance Tab
   • We could also include this in the Components Tab (I'm not sure how useful this information is on a regular basis)

[rwjblue]

Awesome, thank you for putting this together!

[wycats]

re: performance tab -- it was nice to be able to see the latest render time right next to the view without digging into more lists, but I think it would just be fine to add it to the component.

Secondly, and only tangentially related, what would be needed to add the invocation arguments to the components tab?

[rwjblue]

totally agreed on both counts, we already have an issue open RE: fixing up the display of custom components on the components tab and I think as part of that effort we will likely also try to add invocation arguments (at least the names of the arguments, if not the current values)

[wycats]

It seems like it would be possible to snapshot the ARGS references and peek at them if the user clicks on the argument slot, right?

[nummi]

@wycats Something like this?
https://codepen.io/nummi/details/mvJwbq

[nummi]

@wycats

it was nice to be able to see the latest render time right next to the view without digging into more lists, but I think it would just be fine to add it to the component.

Are you always glancing over to see render times or only when your mind is in performance tuning mode? Do you think this is something that should always be visible in the components tab?

[nummi]

Or we could not have a checkbox toggle and always show the render times.

[RobbieTheWagner]

@nummi do you know if other dev tools for React, Vue, etc incorporate render times?

[nummi]

The React devtools have a Profiler screen where you can see render times for components.

The Elements screen does not display this information.

The Vue devtools don't have any performance related data that I'm aware of.

[RobbieTheWagner]

@nummi I believe we can see all that in the normal devtools performance tab, with the addition of ember-perf-timeline correct? https://github.com/ember-best-practices/ember-perf-timeline

I'm unsure if we want to build this into inspector or not, but if we did, I think it would warrant a separate tab as well.

[nummi]

Oh sorry, I was just responding to your question if other dev tools incorporate render times. I think the graphs could be a useful alternative to a table and might have a home in our Render Performance tab but that would be way in the future.

[nummi]

Closing for PR. Please continue conversation there.

#941