Name Known Ember Mixins#1055
Merged
RobbieTheWagner merged 1 commit intoemberjs:masterfrom Nov 15, 2019
Merged
Conversation
ghost
reviewed
Nov 7, 2019
| /** | ||
| * Add Known Ember Mixins and Classes so we can label them correctly in the inspector | ||
| */ | ||
| const emberNames = new Map(); |
There was a problem hiding this comment.
NOTE: this is a nitpick but you can instantiate a Map directly from an array. I find it clearer:
const emberNames = new Map([
[Ember.Evented, 'Evented Mixin']
]);| * @param value | ||
| * @returns {string} | ||
| */ | ||
| function typeOf(value) { |
Member
There was a problem hiding this comment.
@patricklx shouldn't this not be here, since we merged the typeOf stuff?
remove properties set by mixins unless different value caused them to hide the class with only merged mixins from Object.extend(mix1, mix2)
patricklx
force-pushed
the
improve-mixin-names
branch
from
372f21b to
0610c1d
Compare
RobbieTheWagner
approved these changes
Nov 15, 2019
nummi
pushed a commit
to nummi/ember-inspector
that referenced
this pull request
Apr 1, 2020
remove properties set by mixins unless different value caused them to hide the class with only merged mixins from Object.extend(mix1, mix2)
nummi
pushed a commit
to nummi/ember-inspector
that referenced
this pull request
Apr 5, 2020
remove properties set by mixins unless different value caused them to hide the class with only merged mixins from Object.extend(mix1, mix2)
patricklx
added a commit
to patricklx/ember-inspector
that referenced
this pull request
Sep 19, 2022
remove properties set by mixins unless different value caused them to hide the class with only merged mixins from Object.extend(mix1, mix2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
set the names of known mixins
remove properties set by mixins unless different value
causes them to hide the class with only merged mixins from Object.extend(mix1, mix2)