Conversation
| run: yarn ember build --environment production | ||
| - name: Pack | ||
| run: | | ||
| VERSION="$(jq -r '.version | split("+") | .[0]' package.json)" |
There was a problem hiding this comment.
Is this taking the version from package.json? If so, would this be the wrong version since it's always one minor version higher?
There was a problem hiding this comment.
This seems correct. If it's a nightly, the package.json version has already been amended in the previous step with "-alpha.($date)+($sha)", if it is a tag, so long as the directions to not bump the version in package.json were followed, the version should be correct.
There was a problem hiding this comment.
@rwwagner90 yeah, it will be the version on master but only for nightly builds and as @kategengler said it will have the alpha and date stamp on it, so today’s would be v3.13.0-alpha.2019.11.14+abcdef. Anyway; this particular step just have to match what yarn pack decides to name the gzip file, which is taken from package.json (but excluding the +...).
chancancode
force-pushed
the
auto-publish
branch
from
f2832c3 to
a4d4b19
Compare
This should have been included in #1080, it was needed for the npm publishing step.
This should have been included in #1080, it was needed for the npm publishing step.
(cherry picked from commit 334e387)
This should have been included in emberjs#1080, it was needed for the npm publishing step.
This should have been included in emberjs#1080, it was needed for the npm publishing step.
This should have been included in emberjs#1080, it was needed for the npm publishing step.
3 participants
v3.12.3?