Skip to content

Fix inspector in Electron #1084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chancancode merged 1 commit into from
Nov 14, 2019
Merged

Fix inspector in Electron #1084

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions skeletons/web-extension/background-script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,12 @@
* @param {Boolean} force don't use the activeTabs array to check for an existing context menu
*/
function updateContextMenu(force) {
// The Chromium that Electron runs does not have a chrome.contextMenus,
// so make sure this doesn't throw an error in Electron
if (!chrome.contextMenus) {
return;
}

// Only add context menu item when an Ember app has been detected
var isEmberApp = !!activeTabs[activeTabId] || force;
if (!isEmberApp && contextMenuAdded) {
Expand Down
⚡