Skip to content

Fix canary test failure#1130

Merged
RobbieTheWagner merged 1 commit intomasterfrom
fix-canary-tests
Jan 13, 2020
Merged

Fix canary test failure#1130
RobbieTheWagner merged 1 commit intomasterfrom
fix-canary-tests

Conversation

@chancancode
Copy link
Copy Markdown
Member

@RobbieTheWagner
Copy link
Copy Markdown
Member

@chancancode it seems like there is another canary failure

@chancancode
Copy link
Copy Markdown
Member Author

I’ll investigate 🧐

@RobbieTheWagner
Copy link
Copy Markdown
Member

@chancancode are we able to specify allowed failures with github actions? I think we allowed canary to fail before.

@RobbieTheWagner
Copy link
Copy Markdown
Member

I made the canary tests not required, so we can merge this in.

@RobbieTheWagner RobbieTheWagner merged commit 0a592cb into master Jan 13, 2020
@delete-merged-branch delete-merged-branch Bot deleted the fix-canary-tests branch January 13, 2020 20:29
wycats pushed a commit that referenced this pull request Feb 20, 2020
(cherry picked from commit 0a592cb)
nummi pushed a commit to nummi/ember-inspector that referenced this pull request Apr 1, 2020
nummi pushed a commit to nummi/ember-inspector that referenced this pull request Apr 5, 2020
patricklx pushed a commit to patricklx/ember-inspector that referenced this pull request Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants