Merged
Conversation
mixonic
force-pushed
the
mixonic/more-ember-table
branch
from
bf11b09 to
95d8d3e
Compare
RobbieTheWagner
approved these changes
Jan 13, 2020
Member
|
@mixonic this looks good, thanks! Unfortunately, we've got some canary failures (unrelated to this PR) we need to figure out before we can merge. |
Member
Author
|
Looks like the upstream issue for master failures is emberjs/ember.js#18673 |
wycats
pushed a commit
that referenced
this pull request
Feb 20, 2020
* Bump Ember Table to 2.2.2 * await ember-table rendering before asserting DOM Co-authored-by: Robert Wagner <rwwagner90@gmail.com> (cherry picked from commit 14584c7)
nummi
pushed a commit
to nummi/ember-inspector
that referenced
this pull request
Apr 1, 2020
* Bump Ember Table to 2.2.2 * await ember-table rendering before asserting DOM Co-authored-by: Robert Wagner <rwwagner90@gmail.com>
nummi
pushed a commit
to nummi/ember-inspector
that referenced
this pull request
Apr 5, 2020
* Bump Ember Table to 2.2.2 * await ember-table rendering before asserting DOM Co-authored-by: Robert Wagner <rwwagner90@gmail.com>
patricklx
pushed a commit
to patricklx/ember-inspector
that referenced
this pull request
Sep 19, 2022
* Bump Ember Table to 2.2.2 * await ember-table rendering before asserting DOM Co-authored-by: Robert Wagner <rwwagner90@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The diff: Addepar/ember-table@v2.1.3...v2.2.2
Would unblock Ember 3.15 among other minor fixes.