Component Tree Arrow Key Navigation#1153
Merged
RobbieTheWagner merged 2 commits intoemberjs:masterfrom Mar 7, 2020
Merged
Conversation
nummi
force-pushed
the
component-tree-arrow-key-navigation
branch
2 times, most recently
from
506d3b2 to
70cf262
Compare
Member
I think only if the component tree window is focused, but we would need to make sure it is focusable with tab, etc.
I would be fine with not allowing holding down personally. |
nummi
force-pushed
the
component-tree-arrow-key-navigation
branch
from
70cf262 to
6338007
Compare
Contributor
Author
|
Changed to always use arrow keys when the component tree is visible unless focus is in an input or textarea. |
nummi
changed the title
nummi
force-pushed
the
component-tree-arrow-key-navigation
branch
from
6338007 to
25f0050
Compare
nummi
force-pushed
the
component-tree-arrow-key-navigation
branch
from
25f0050 to
191597f
Compare
RobbieTheWagner
approved these changes
Mar 7, 2020
Member
RobbieTheWagner
left a comment
RobbieTheWagner
left a comment
There was a problem hiding this comment.
This looks great. Thanks for taking this on!
nummi
added a commit
to nummi/ember-inspector
that referenced
this pull request
Apr 1, 2020
* Key codes utility * Navigate component tree with arrow keys
nummi
added a commit
to nummi/ember-inspector
that referenced
this pull request
Apr 5, 2020
* Key codes utility * Navigate component tree with arrow keys
patricklx
pushed a commit
to patricklx/ember-inspector
that referenced
this pull request
Sep 19, 2022
* Key codes utility * Navigate component tree with arrow keys
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1142
@NullVoxPopuli, here is a WIP.