More functional classes and data-test selectors#1168
Merged
RobbieTheWagner merged 2 commits intoemberjs:masterfrom Apr 18, 2020
Merged
More functional classes and data-test selectors#1168RobbieTheWagner merged 2 commits intoemberjs:masterfrom
RobbieTheWagner merged 2 commits intoemberjs:masterfrom
Conversation
Member
|
Will review this sometime this week. Apologies for the delay! |
nummi
force-pushed
the
functional-css-data-test-april
branch
2 times, most recently
from
fe5ee48 to
689b08d
Compare
RobbieTheWagner
approved these changes
Apr 5, 2020
Member
RobbieTheWagner
left a comment
RobbieTheWagner
left a comment
There was a problem hiding this comment.
LGTM! Just one question
Member
|
@chancancode any ideas why GitHub actions refuses to run here? |
Member
|
@nummi can you try rebasing or pushing just a new space added or something? Trying to kick GitHub actions into actually running. |
nummi
force-pushed
the
functional-css-data-test-april
branch
from
8d6c6d4 to
24811b6
Compare
Member
This means it couldn't download the version of node needed for the build. nodejs/nodejs.org#3075 |
Member
|
@nummi looks like we have a conflict here. Sorry about that! Do you mind resolving? I think we can merge after that. |
nummi
force-pushed
the
functional-css-data-test-april
branch
from
24811b6 to
b42abc0
Compare
patricklx
pushed a commit
to patricklx/ember-inspector
that referenced
this pull request
Sep 19, 2022
* More functional classes and data-test selectors * Fix broken object inspector tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved a lot of styles from
app/stylesto functional classes.(also moved a bunch of test selectors to
data-test)