Fix string arguments in component tree to render only one pair of double quotes fixes #1190#1193
Conversation
|
Unfortunately we don't have a good way to test this right now, the integration test harness is broken for some reason, but I'm looking into it. |
|
I forget why we needed this stuff in the first place. Were we trying to handle if the strings included |
|
@rwwagner90 Yeah, the surrounding quotes is added in the template outside, so that the quotes are not part of the highlighting. This point is mostly moot now that we refactored it from being a helper to the component, and the component has its own template. This is the refactor that I was referring to. The quotes should still be added in template-land (instead of inside this JavaScript function), just that it should be moved from the tree-item component template into the tree-arg component template. |
|
Thanks @rwjblue @chancancode @rwwagner90! |
…ble quotes fixes emberjs#1190 (emberjs#1193) * Fix string arguments in component tree to render only one pair of double quotes * Add component integration test for component-tree-arg
This was a bad merge while experimenting with refactoring the surrounding string code for argument values.
Reverting the logic back to the way it was here: https://github.com/emberjs/ember-inspector/pull/1175/files#diff-a9290a87bac9f17e7512cb19a835f822L14 (in
app/helpers/component-argument.js)After fix