Prevent future ember/no-mixins eslint error#1219
Merged
RobbieTheWagner merged 2 commits intoemberjs:masterfrom May 17, 2020
ansmonjol:prevent-no-mixins
Merged
Prevent future ember/no-mixins eslint error#1219RobbieTheWagner merged 2 commits intoemberjs:masterfrom ansmonjol:prevent-no-mixins
RobbieTheWagner merged 2 commits intoemberjs:masterfrom
ansmonjol:prevent-no-mixins
Conversation
rwjblue
reviewed
May 16, 2020
Member
rwjblue
left a comment
rwjblue
left a comment
There was a problem hiding this comment.
Can you enable the rule in our eslint config (that should allow us to confirm it doesn’t error and whatnot)?
Author
Of course ! Done |
RobbieTheWagner
approved these changes
May 17, 2020
patricklx
pushed a commit
to patricklx/ember-inspector
that referenced
this pull request
Sep 19, 2022
* Prevent future ember/no-mixins eslint error * Enable no-mixins rule
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This MR aims to fix the future
ember/no-mixinserror, while upgrading eslint-plugin-ember from 7.13.0 to 8.5.1.Preferred to disable the lint on each occurence instead of disabling the rule globally, as we did for observers.
See related issue: #1197
And the rule documentation: https://github.com/ember-cli/eslint-plugin-ember/blob/master/docs/rules/no-mixins.md