[Glimmer] The view tree now supports glimmer#357
Merged
teddyzeenny merged 1 commit intoemberjs:masterfrom May 12, 2015
Merged
Conversation
There was a shift in concept from a view tree to a render node tree. Previously, the template tree was made of a hierarchy of view instances. After the Glimmer rewrite, view instances are optional and secondary, and the main template representation is a render node tree. This required a re-write of all of view-debug.js. Old code was left untouched, so the current version supports both pre-glimmer and post-glimmer. We detect glimmer by checking for the absence of `_childViews` on the top level view. All code that touches private api (anything that has to do with render nodes) needs to be moved to Ember core and tested.
Member
|
👍 |
teddyzeenny
added a commit
that referenced
this pull request
May 12, 2015
[Glimmer] The view tree now supports glimmer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #351
Fixes emberjs/ember.js#11027
Fixes #356
There was a shift in concept from a view tree to a render node tree.
Previously, the template tree was made of a hierarchy of view instances.
After the Glimmer rewrite, view instances are optional and secondary, and the main template representation is a render node tree.
This required a re-write of all of view-debug.js. Old code was left untouched, so the current version supports both pre-glimmer and post-glimmer. We detect glimmer by checking for the absence of
_childViewson the top level view.All code that touches private api (anything that has to do with render nodes) needs to be moved to Ember core and tested.