Save _super before reopening#481
Merged
teddyzeenny merged 1 commit intoemberjs:masterfrom Oct 7, 2015
Merged
Conversation
If you call `reopen` in an object's method on the object itself `_super` will be reset and can no longer be used. This stores `_super` in a variable to we can call it later.
teddyzeenny
added a commit
that referenced
this pull request
Oct 7, 2015
Save _super before reopening
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you call
reopenin an object's method on the object itself_superwill be reset and can no longer be used.This stores
_superin a variable to we can call it later.Fixes #461
Fixes #478
Fixes emberjs/ember.js#12439