Skip to content

[WIP] Trying to fix beta and canary#787

Merged
RobbieTheWagner merged 3 commits intomasterfrom
fix-beta
Apr 17, 2018
Merged

[WIP] Trying to fix beta and canary#787
RobbieTheWagner merged 3 commits intomasterfrom
fix-beta

Conversation

@RobbieTheWagner
Copy link
Copy Markdown
Member

Our builds are all failing now, due to ember-beta and ember-canary changes. I'm working to resolve some of the issues here, but if anyone knows of specific things I should be on the lookout for and definitely change, let me know!

cc @rwjblue @teddyzeenny

@rwjblue
Copy link
Copy Markdown
Member

rwjblue commented Apr 16, 2018

See emberjs/ember.js#16478 for details. I believe that PR was closed and reopened as emberjs/ember.js#16499 (review) (which was just merged).

Can you double check if that was the only change required? I’ll get it cherry picked into beta before the next one gets cut...

@RobbieTheWagner
Copy link
Copy Markdown
Member Author

@rwjblue I tried latest canary and I see another issue:

not ok 14 Chrome 65.0 - Ember Debug - Object Inspector: Property grouping can be customized using _debugInfo
    ---
        actual: >
            null
        stack: >
            TypeError: Cannot add property __NAME_KEY__ember15238817701531233187778522__, object is not extensible

There are also a couple more failures, related to things like this.get(...).on is not a function, but I think maybe those are just things we need to update?

@rwjblue
Copy link
Copy Markdown
Member

rwjblue commented Apr 16, 2018

That failure is the thing reported in emberjs/ember.js#16479, I'm working on a PR to fix it now...

@RobbieTheWagner
Copy link
Copy Markdown
Member Author

@rwjblue canary is passing now, so we should be green, or mostly green when a new beta release is cut. Thanks so much for everything you do! 😄

@RobbieTheWagner RobbieTheWagner merged commit 1639fb6 into master Apr 17, 2018
@RobbieTheWagner RobbieTheWagner deleted the fix-beta branch April 17, 2018 03:07
cyril-sf pushed a commit to cyril-sf/ember-inspector that referenced this pull request Mar 30, 2022
* Fix setIsDragging test errors

* Fix lint

* Pass setIsDragging where missed, use layoutService instead of layout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants