[WIP] Trying to fix beta and canary#787
Merged
RobbieTheWagner merged 3 commits intomasterfrom Apr 17, 2018
Merged
Conversation
Member
|
See emberjs/ember.js#16478 for details. I believe that PR was closed and reopened as emberjs/ember.js#16499 (review) (which was just merged). Can you double check if that was the only change required? I’ll get it cherry picked into beta before the next one gets cut... |
Member
Author
|
@rwjblue I tried latest canary and I see another issue: There are also a couple more failures, related to things like |
Member
|
That failure is the thing reported in emberjs/ember.js#16479, I'm working on a PR to fix it now... |
Member
Author
|
@rwjblue canary is passing now, so we should be green, or mostly green when a new beta release is cut. Thanks so much for everything you do! 😄 |
cyril-sf
pushed a commit
to cyril-sf/ember-inspector
that referenced
this pull request
Mar 30, 2022
* Fix setIsDragging test errors * Fix lint * Pass setIsDragging where missed, use layoutService instead of layout
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our builds are all failing now, due to ember-beta and ember-canary changes. I'm working to resolve some of the issues here, but if anyone knows of specific things I should be on the lookout for and definitely change, let me know!
cc @rwjblue @teddyzeenny