Conversation
RobbieTheWagner
left a comment
RobbieTheWagner
left a comment
There was a problem hiding this comment.
This looks awesome! Just one question to see what your thoughts were on using autoprefixer.
|
|
||
| .mixin__name { | ||
| position: relative; | ||
| position: -webkit-sticky; |
There was a problem hiding this comment.
Rather than trying to get all the prefixes in our styles, should we just use https://github.com/kimroen/ember-cli-autoprefixer?
There was a problem hiding this comment.
Your call. We use -webkit twice in the CSS (including this PR).
There was a problem hiding this comment.
I suppose it's no big deal then.
RobbieTheWagner
left a comment
RobbieTheWagner
left a comment
There was a problem hiding this comment.
This looks good to me! Is it ready to merge? Will it conflict with any of the other work in the other PRs?
Ready to merge — it shouldn't cause any issues with the other PRs. |
|
Merged, thanks! 🎉 |
2 participants
See animated GIF below (ignore the colors).
Also made an adjustment to an SVG that was throwing an svg-jar warning in the command line.