Color Variables Cleanup#806
Merged
RobbieTheWagner merged 5 commits intoemberjs:masterfrom May 28, 2018
Merged
Conversation
- remove unused colors - remove colors that are similar to others
- remove unused colors - remove colors that are similar to others
nummi
commented
May 24, 2018
| --base13: #404040; | ||
| --base14: #333333; | ||
| --base15: #222222; | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Shades of gray cut in half and I can't see any difference. Waaaat.
RobbieTheWagner
approved these changes
May 24, 2018
Member
RobbieTheWagner
left a comment
RobbieTheWagner
left a comment
There was a problem hiding this comment.
Nice! This should be a lot easier to maintain, with less colors. I do see very slight changes, but I think it looks close enough 👍
cyril-sf
pushed a commit
to cyril-sf/ember-inspector
that referenced
this pull request
Mar 30, 2022
* Base color cleanup - remove unused colors - remove colors that are similar to others * Special color cleanup - remove unused colors - remove colors that are similar to others * Rename special colors * Source reorder base colors by shade * Rename base colors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If I did my job correctly you won't really see any visual changes.
"Ember application not detected" screen had its own shade of gray and red)
I checked for errors as I made changes and for the final check I loaded the same screen in the dev and prod version of the inspector and switched between tabs watching for glaring differences.