Context menu item for inspecting components#843
Merged
RobbieTheWagner merged 4 commits intoemberjs:masterfrom Jul 28, 2018
Merged
Context menu item for inspecting components#843RobbieTheWagner merged 4 commits intoemberjs:masterfrom
RobbieTheWagner merged 4 commits intoemberjs:masterfrom
Conversation
Relying on the `emberVersion` message as the trigger point for setting the context menu isn't always reliable.
Bestra
force-pushed
the
context-menu-item
branch
from
0932d0c to
7ee982c
Compare
Contributor
Author
|
This PR pretty much adds an extra commit or two onto the work that @thorsteinsson already did, so the credit is firmly his. |
4 tasks
When an item is inspected via the context menu we try to put it into view in the component tree. We make an educated guess as to how far down we should scroll based on the item's index and a magic height number
Bestra
force-pushed
the
context-menu-item
branch
from
7ee982c to
c574c94
Compare
Member
|
Nice work @thorsteinsson and @Bestra! I hate to ask, but any chance we could get some test coverage for this feature? 😄 |
Contributor
Author
|
@rwwagner90 😅 I can probably write an acceptance test that takes an incoming message from the port and highlights a given item. I think that'll cover the happy path for the real thing. Off I go |
RobbieTheWagner
approved these changes
Jul 28, 2018
Member
RobbieTheWagner
left a comment
RobbieTheWagner
left a comment
There was a problem hiding this comment.
This seems great to me! 🎉
Member
|
Great work @Bestra! I'm so happy to see this land. |
cyril-sf
pushed a commit
to cyril-sf/ember-inspector
that referenced
this pull request
Mar 30, 2022
* Context menu item for "Inspect Ember Component" * Try to set context menu when inspector loads Relying on the `emberVersion` message as the trigger point for setting the context menu isn't always reliable. * Scroll component tree to selected item When an item is inspected via the context menu we try to put it into view in the component tree. We make an educated guess as to how far down we should scroll based on the item's index and a magic height number * Add specs for inspecting item via context menu
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Features:
This PR supersedes WIP: Context menu item for "Inspect Ember Component" #788. Closes Implement "Inspect component" contextual menu #689