Fix Ember Inspector during tests for Ember >= 3#855
Merged
teddyzeenny merged 1 commit intoemberjs:masterfrom Aug 3, 2018
Merged
Fix Ember Inspector during tests for Ember >= 3#855teddyzeenny merged 1 commit intoemberjs:masterfrom
teddyzeenny merged 1 commit intoemberjs:masterfrom
Conversation
RobbieTheWagner
approved these changes
Aug 3, 2018
Member
RobbieTheWagner
left a comment
RobbieTheWagner
left a comment
There was a problem hiding this comment.
Looks good to me! Thanks for spending the time to figure this out. It was really stumping me!
rwjblue
approved these changes
Aug 3, 2018
|
Any chance of a patch-level release to get this in? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The primary difference between acceptance tests for Ember < 3 vs Ember >= 3 is that for Ember < 3, every test created a new application + one application instance, whereas in Ember > 3 all the tests use the same application, but a different application instance for each test. The inspector was relying on the application boot, (which only happens once during tests in Ember >=3, and it happens even before the first test starts which was causing the inspector to fail and throw errors as it was starting even before the first application instance was created).
On the plus side, making the inspector only boot on application instance boot (instead of on application boot) also works for prior versions, and feels more "correct", so this should resolve everything everywhere.
Resolves #816
Resolves #818
Closes #846