Flat Display of Object Properties#877
Merged
RobbieTheWagner merged 1 commit intoemberjs:masterfrom Oct 18, 2018
Merged
Conversation
nummi
force-pushed
the
flat-display-of-object-properties
branch
from
315e6a2 to
201ba33
Compare
Contributor
|
Love it 😍 |
nummi
force-pushed
the
flat-display-of-object-properties
branch
from
201ba33 to
cf9126f
Compare
nummi
changed the title
nummi
force-pushed
the
flat-display-of-object-properties
branch
from
cf9126f to
5609428
Compare
Contributor
Author
|
I think this is ready for review now. I did my best to use what was already there ( |
nummi
force-pushed
the
flat-display-of-object-properties
branch
from
5609428 to
24c144c
Compare
nummi
commented
Oct 16, 2018
| return (val instanceof EmberObject) || typeOf(val) === 'array'; | ||
| }, | ||
|
|
||
| saveProperty(objectId, mixinIndex, prop, val) { |
Contributor
Author
There was a problem hiding this comment.
mixinIndex was not being used — confirmed with Teddy
RobbieTheWagner
approved these changes
Oct 17, 2018
Member
RobbieTheWagner
left a comment
RobbieTheWagner
left a comment
There was a problem hiding this comment.
This looks awesome to me! 😍
Member
|
@nummi @teddyzeenny any idea on these tests failures? |
Contributor
Author
|
No idea! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#364