Don't send count if the object is destroyed#884
Merged
RobbieTheWagner merged 2 commits intoemberjs:masterfrom Nov 28, 2018
Merged
Don't send count if the object is destroyed#884RobbieTheWagner merged 2 commits intoemberjs:masterfrom
RobbieTheWagner merged 2 commits intoemberjs:masterfrom
Conversation
Member
Author
|
This fix worked for me, I wonder why |
Member
|
@thorsteinsson I am not sure why it is not working, but doing extra checks to be sure seems fine 👍 |
RobbieTheWagner
approved these changes
Nov 28, 2018
cyril-sf
pushed a commit
to cyril-sf/ember-inspector
that referenced
this pull request
Mar 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #864.