Merged
Conversation
I'm using styleline-config-ship-shape here, but open to other configs, if we don't want this one. One of the main changes to note is things are alphabetized.
thorsteinsson
approved these changes
Dec 2, 2018
| .component-tree-item__bracket::after { | ||
| content: '}}'; | ||
|
|
||
| .component-tree-item__bracket:after { |
Member
There was a problem hiding this comment.
Minor: psuedo elements in CSS should use ::. It's in more places, used for before and after.
Member
Author
There was a problem hiding this comment.
The stylelint rules have a rule to use a single :. I prefer the single, but not a big deal either way to me.
pbishop16
suggested changes
Dec 2, 2018
pbishop16
approved these changes
Dec 3, 2018
cyril-sf
pushed a commit
to cyril-sf/ember-inspector
that referenced
this pull request
Mar 30, 2022
* Enforce stylelint I'm using styleline-config-ship-shape here, but open to other configs, if we don't want this one. One of the main changes to note is things are alphabetized. * Add missing px, remove standard stylelint config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm using styleline-config-ship-shape here, but open to other configs, if we don't want this one. One of the main changes to note is things are alphabetized.