alt/option click to toggle children in component tree#925
Merged
RobbieTheWagner merged 2 commits intoemberjs:masterfrom Feb 6, 2019
Merged
alt/option click to toggle children in component tree#925RobbieTheWagner merged 2 commits intoemberjs:masterfrom
RobbieTheWagner merged 2 commits intoemberjs:masterfrom
Conversation
locks
reviewed
Jan 29, 2019
Member
|
Seems neat! |
locks
reviewed
Jan 29, 2019
nummi
force-pushed
the
key-to-toggle-component-children
branch
2 times, most recently
from
774005b to
fed4d2a
Compare
nummi
changed the title
nummi
force-pushed
the
key-to-toggle-component-children
branch
3 times, most recently
from
9b358be to
4668c62
Compare
nummi
force-pushed
the
key-to-toggle-component-children
branch
from
4668c62 to
2623ee5
Compare
RobbieTheWagner
approved these changes
Feb 4, 2019
locks
approved these changes
Feb 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can currently expand/collapse ALL items but not in any granular fashion without a lot of clicking. This can be a pain to explore large component trees. With this PR I'm proposing we copy the MacOS style (I'm sure other platforms have something similar) of expanding/collapsing children nodes by alt/option clicking on a disclosure triangle.
Option click
{{es-header}}and it will fold and so will all the children.