Deprecate tryFinally and tryCatchFinally#10667
Merged
rwjblue merged 1 commit intoemberjs:masterfrom Mar 19, 2015
Merged
Conversation
Member
|
we also use this internally to mitigate that old safari bug.
|
Member
Author
|
@stefanpenner I don't think we can remove internal usages until 2.0 since it would mean dropping browser support. The number of desktop users affected is very small since it is present in early Safari 6.0 but is fixed by 6.0.5. However, all iOS 6 users are susceptible. I've tested on both 6.0 and 6.1. According to http://david-smith.org/iosversionstats/, 5% of users still use iOS 6.x. While I think we can make a good case for dropping this is 2.0, I don't think we can drop from 1.x. |
Member
sounds good. |
rwjblue
added a commit
that referenced
this pull request
Mar 19, 2015
Deprecate tryFinally and tryCatchFinally
Member
Author
|
@rwjblue Did we want a deprecation link for this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still needs deprecation link