Skip to content

Deprecate tryFinally and tryCatchFinally#10667

Merged
rwjblue merged 1 commit intoemberjs:masterfrom
wagenet:deprecate-try-catch-finally
Mar 19, 2015
Merged

Deprecate tryFinally and tryCatchFinally#10667
rwjblue merged 1 commit intoemberjs:masterfrom
wagenet:deprecate-try-catch-finally

Conversation

@wagenet
Copy link
Copy Markdown
Member

@wagenet wagenet commented Mar 19, 2015

Still needs deprecation link

@stefanpenner
Copy link
Copy Markdown
Member

we also use this internally to mitigate that old safari bug.

  • Are we also dropping support for that version of safari?
  • do we need to remove those deprecated internal usages?

@wagenet
Copy link
Copy Markdown
Member Author

wagenet commented Mar 19, 2015

@stefanpenner I don't think we can remove internal usages until 2.0 since it would mean dropping browser support. The number of desktop users affected is very small since it is present in early Safari 6.0 but is fixed by 6.0.5. However, all iOS 6 users are susceptible. I've tested on both 6.0 and 6.1. According to http://david-smith.org/iosversionstats/, 5% of users still use iOS 6.x. While I think we can make a good case for dropping this is 2.0, I don't think we can drop from 1.x.

@stefanpenner
Copy link
Copy Markdown
Member

While I think we can make a good case for dropping this is 2.0, I don't think we can drop from 1.x.

sounds good.

rwjblue added a commit that referenced this pull request Mar 19, 2015
Deprecate tryFinally and tryCatchFinally
@rwjblue rwjblue merged commit ee305d2 into emberjs:master Mar 19, 2015
@wagenet
Copy link
Copy Markdown
Member Author

wagenet commented Mar 20, 2015

@rwjblue Did we want a deprecation link for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants