Fix for exceptions in Wasm Workers under node#26650
Open
sbc100 wants to merge 1 commit intoemscripten-core:mainfrom
Open
Fix for exceptions in Wasm Workers under node#26650sbc100 wants to merge 1 commit intoemscripten-core:mainfrom
sbc100 wants to merge 1 commit intoemscripten-core:mainfrom
Conversation
Without this change exceptions thrown in Wasm Workers are lost under node.
sbc100
force-pushed
the
node_worker_exceptions
branch
from
34ab26a to
dccc94a
Compare
Member
|
what is different about wasm workers here compared to pthreads? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this change exceptions thrown in Wasm Workers are lost under node because we install an
uncaughtExceptionon all workers inruntime_common.js.