Test staticfiles#5701
Merged
carltongibson merged 4 commits intoencode:masterfrom Jan 2, 2018
Merged
Conversation
carltongibson
approved these changes
Jan 2, 2018
Collaborator
carltongibson
left a comment
carltongibson
left a comment
There was a problem hiding this comment.
Yep. Looks good. 👍
pchiquet
pushed a commit
to pchiquet/django-rest-framework
that referenced
this pull request
Nov 17, 2020
* Remove 'MIDDLEWARE_CLASSES' compat setting * Remove 'django.setup()' compat import * Move '--no-pkgroot' handling to conftest * Add staticfiles handling to dist build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test for #5692. This is committed in the same vein as #5700, which is based off of d12005c (added the dist build). Tests will fail locally (as expected), but the merge commit in CI causes this to pass (as expected, since master contains the fixed MANIFEST.in).
By default
ManifestStaticFilesStorageis strict in that missing static files will raise exceptions during thecollectstaticcall. The missing .woff2 and .ico files would have been caught by this.