Skip to content

Add basic translation tests#5700

Merged
carltongibson merged 1 commit intoencode:masterfrom
rpkilby:test-translations
Jan 2, 2018
Merged

Add basic translation tests#5700
carltongibson merged 1 commit intoencode:masterfrom
rpkilby:test-translations

Conversation

@rpkilby
Copy link
Copy Markdown
Contributor

@rpkilby rpkilby commented Dec 21, 2017

Test for #5696.

This PR is based off of the commit that adds the dist build, which doesn't include the fix from #5696. Running the tests locally, this fails. However, Travis creates a merge commit from the current master, so this passes in CI.

@rpkilby rpkilby mentioned this pull request Dec 21, 2017
@rpkilby
Copy link
Copy Markdown
Contributor Author

rpkilby commented Dec 21, 2017

One thought - I'm not sure if translation tests will interact poorly to potential message changes and our use of transifex. As an example, let's say the exception message for the standard APIException is changed from "A server error occurred." to "An internal server error occurred.". This change would result in a test failure, since there's no corresponding french translation for the updated message.

Would we just need to temporarily fix the translation files, then ensure that transifex is updated as well?

Copy link
Copy Markdown
Collaborator

@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My thought for this was just to do some kind of find... on the dist build to make sure the file is there. ???

Copy link
Copy Markdown
Collaborator

@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should have this. I would have caught the issues with the 3.7.4-.7 releases.

If the test proves fragile we can adjust the strategy. (It should be fine though...)

@carltongibson carltongibson added this to the 3.8 Release milestone Jan 2, 2018
@carltongibson carltongibson merged commit 3515039 into encode:master Jan 2, 2018
@rpkilby rpkilby deleted the test-translations branch January 3, 2018 22:53
pchiquet pushed a commit to pchiquet/django-rest-framework that referenced this pull request Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants