Add basic translation tests#5700
Conversation
|
One thought - I'm not sure if translation tests will interact poorly to potential message changes and our use of transifex. As an example, let's say the exception message for the standard APIException is changed from Would we just need to temporarily fix the translation files, then ensure that transifex is updated as well? |
carltongibson
left a comment
There was a problem hiding this comment.
My thought for this was just to do some kind of find... on the dist build to make sure the file is there. ???
carltongibson
left a comment
There was a problem hiding this comment.
I think we should have this. I would have caught the issues with the 3.7.4-.7 releases.
If the test proves fragile we can adjust the strategy. (It should be fine though...)
Test for #5696.
This PR is based off of the commit that adds the
distbuild, which doesn't include the fix from #5696. Running the tests locally, this fails. However, Travis creates a merge commit from the current master, so this passes in CI.