Fixed _force_text_recursive typo#3908
Merged
xordoquy merged 2 commits intoencode:masterfrom Feb 12, 2016
KostyaEsmukov:fix_exceptions_force_text
Merged
Fixed _force_text_recursive typo#3908xordoquy merged 2 commits intoencode:masterfrom KostyaEsmukov:fix_exceptions_force_text
xordoquy merged 2 commits intoencode:masterfrom
KostyaEsmukov:fix_exceptions_force_text
Conversation
Contributor
|
Interesting, I'm wondering how this looked like before vs with this change. |
Contributor
Author
|
Something like this. Before: After: |
Contributor
|
I'm just wondering how or why this wasn't raised before. @xordoquy any ideas? |
Contributor
|
That's a somewhat minor side effect for the display. |
Contributor
|
Note that in the end the lazy object will get translated anyway which is why I said it was minor. |
Contributor
|
Good catch, thanks for the PR ! |
xordoquy
added a commit
that referenced
this pull request
Feb 12, 2016
Fixed _force_text_recursive typo
nazarewk
pushed a commit
to 10clouds/django-rest-framework
that referenced
this pull request
Apr 5, 2016
This was referenced Mar 9, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like a typo.
Steps to reproduce: