DateTimeField to_representation can handle strings. Fixes #4013.#4019
Closed
calumcalder wants to merge 3 commits intoencode:masterfrom
Closed
DateTimeField to_representation can handle strings. Fixes #4013.#4019calumcalder wants to merge 3 commits intoencode:masterfrom
calumcalder wants to merge 3 commits intoencode:masterfrom
Conversation
| return value | ||
|
|
||
| if output_format.lower() == ISO_8601: | ||
| if isinstance(value, str): |
Contributor
There was a problem hiding this comment.
This should be six.binary_type
Author
There was a problem hiding this comment.
Should it not be six.string_types?
Python 2.7.6
>>> isinstance('2001-01-01T01:01', six.binary_type)
True
>>> isinstance('2001-01-01T01:01', six.string_types)
True
Whereas
Python 3.4.3
>>> isinstance('2001-01-01T01:01', six.binary_type)
False
>>> isinstance('2001-01-01T01:01', six.string_types)
True
Given that Python 2's datetime.datetime.strptime function does not accept '+HHMM' strings with the format directive '%z', the tests for accepting such strings have been ommitted for python 2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue with DateTimeField described in #4013.