Change ImageField validation pattern#5539
Merged
carltongibson merged 1 commit intoencode:masterfrom Nov 6, 2017
sazarkin:i5534
Merged
Change ImageField validation pattern#5539carltongibson merged 1 commit intoencode:masterfrom sazarkin:i5534
carltongibson merged 1 commit intoencode:masterfrom
sazarkin:i5534
Conversation
Collaborator
|
@sazarkin OK. Thanks for this. I need to have a think about whether this is the right approach. (Given the comment, it could well be.) |
carltongibson
approved these changes
Nov 6, 2017
Collaborator
carltongibson
left a comment
carltongibson
left a comment
There was a problem hiding this comment.
This looks good: the move to clean from to_python will just apply the validator (for all versions for which it is present)
I can't see a problem there. (Since we've stubbed the testing I don't see what else we can reasonably do.)
Thanks!
|
The Django extension validation fails when there's no extension in the name. What you guys think about considering content type instead of name for validation? |
Collaborator
|
HI @suparnaj3. Sounds good in theory but it's making it work, and tests. (If it's something you want to put a proof-of-concept together for, I'm sure we'd love to have a look 🙂) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #5534
Well it is fixes the issue. But I don't know how to test this.
Probably there is a different way to resolve this problem.