Deprecate DjangoObjectPermissionsFilter#6075
Merged
carltongibson merged 1 commit intoencode:masterfrom Oct 2, 2018
Merged
Conversation
Contributor
Author
|
Adding to the 3.9 milestone to ensure it's reviewed. |
carltongibson
force-pushed
the
deprecate-django-guardian
branch
from
a68d266 to
2667635
Compare
pchiquet
pushed a commit
to pchiquet/django-rest-framework
that referenced
this pull request
Nov 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the discussion in #6038, the objective is to move django-guardian integrations out of the core framework and into a 3rd-party package. Motivating factors are in this comment.
This PR is fairly straightforward, as
DjangoObjectPermissionsFilteris the only direct integration.DjangoObjectPermissionsjust hooks into the object-level permissions and isn't directly dependent.3rd-party package: https://github.com/rpkilby/django-rest-framework-guardian