Skip to content

Ensure serializer and field validators support both lists and tuples#6282

Merged
carltongibson merged 1 commit intoencode:masterfrom
fengsi:6280
Feb 19, 2019
Merged

Ensure serializer and field validators support both lists and tuples#6282
carltongibson merged 1 commit intoencode:masterfrom
fengsi:6280

Conversation

@fengsi
Copy link
Copy Markdown

@fengsi fengsi commented Oct 26, 2018

This PR fixes #6280.

@fengsi fengsi changed the title Allow field validators parameter to be iterable (#6280) Allow field validators parameter to be iterables (#6280) Oct 26, 2018
Copy link
Copy Markdown
Contributor

@rpkilby rpkilby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rpkilby rpkilby added this to the 3.9.1 Release milestone Oct 26, 2018
Comment thread tests/test_fields.py
Comment thread rest_framework/serializers.py
@rpkilby rpkilby changed the title Allow field validators parameter to be iterables (#6280) Ensure serializer and field support both lists and tuples Oct 26, 2018
@rpkilby rpkilby changed the title Ensure serializer and field support both lists and tuples Ensure serializer and field validators support both lists and tuples Oct 26, 2018
@fengsi fengsi changed the title Ensure serializer and field validators support both lists and tuples Allow field validators parameter to be iterables Oct 31, 2018
@fengsi fengsi changed the title Allow field validators parameter to be iterables Ensure serializer and field validators support both lists and tuples Oct 31, 2018
@carltongibson carltongibson self-requested a review February 14, 2019 20:19
Copy link
Copy Markdown
Collaborator

@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @fengsi. Thanks for this.
I rebased and made a few cosmetic changes.

👍

@carltongibson carltongibson merged commit 1ece516 into encode:master Feb 19, 2019
@fengsi fengsi deleted the 6280 branch March 5, 2019 20:32
pchiquet pushed a commit to pchiquet/django-rest-framework that referenced this pull request Nov 17, 2020
sigvef pushed a commit to sigvef/django-rest-framework that referenced this pull request Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

validators parameter in field cannot deal with tuple

5 participants