[BugFix] add "allow_unicode" option to ModelSerializer SlugField#6315
Merged
carltongibson merged 1 commit intoencode:masterfrom Dec 19, 2018
Merged
[BugFix] add "allow_unicode" option to ModelSerializer SlugField#6315carltongibson merged 1 commit intoencode:masterfrom
carltongibson merged 1 commit intoencode:masterfrom
Conversation
carltongibson
approved these changes
Dec 19, 2018
Collaborator
carltongibson
left a comment
carltongibson
left a comment
There was a problem hiding this comment.
Yep. This looks good. allow_unicode was added in Django 1.9.
pchiquet
pushed a commit
to pchiquet/django-rest-framework
that referenced
this pull request
Nov 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a SlugField set allow_unicode, the ModelSelializer have not set it.
when user create/update a model, the validator will reject the unicode slug field.
So, this fix add this option in field mapping.