Remove sourceMappingURL from CSS files to fix #8587.#8588
Closed
donkirkby wants to merge 1 commit intoencode:masterfrom
Closed
Remove sourceMappingURL from CSS files to fix #8587.#8588donkirkby wants to merge 1 commit intoencode:masterfrom
donkirkby wants to merge 1 commit intoencode:masterfrom
Conversation
Contributor
|
Closing in favour of #8591. Thanks for your time on progressing this. 🙏🏼 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a problem with Django 4.1, refs #8587.
This is the smallest change, just removing the two
sourceMappingURLlines from the minified CSS files. One downside, however, is that someone upgrading to a new version of bootstrap might accidentally add them back in. Maybe a precommit hook could guard against that.Another option would be to include the source maps, but I thought that was a bigger change.