Skip to content

shellcheck fixes#368

Open
e-kwsm wants to merge 1 commit intoendeavouros-team:masterfrom
e-kwsm:shellcheck
Open

shellcheck fixes#368
e-kwsm wants to merge 1 commit intoendeavouros-team:masterfrom
e-kwsm:shellcheck

Conversation

@e-kwsm
Copy link
Copy Markdown

@e-kwsm e-kwsm commented Dec 12, 2025

  • fix(SC2006): avoid backticked command substitution
  • fix(SC2162): add -r to read
  • fix(SC2166): use [ p ] && [ q ] over [ p -a q ]

@e-kwsm e-kwsm force-pushed the shellcheck branch 2 times, most recently from 2b63362 to 1298b37 Compare December 24, 2025 12:23
@e-kwsm e-kwsm force-pushed the shellcheck branch 2 times, most recently from b43fbfe to 48443e6 Compare January 3, 2026 07:00
@e-kwsm e-kwsm force-pushed the shellcheck branch 3 times, most recently from 92e184c to 73aea5d Compare January 18, 2026 03:07
Copy link
Copy Markdown
Member

@killajoe killajoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@manuel-192
Copy link
Copy Markdown
Collaborator

manuel-192 commented Feb 22, 2026

@e-kwsm
Please note that a fair portion of shellcheck messages are not OK in every case, so they may lead to dysfunctional code if applied.
So if you want to report such things, you must make sure they really fix a problem and not create a problem.

@e-kwsm
Copy link
Copy Markdown
Author

e-kwsm commented Feb 23, 2026

Thank you for your review.

LXDM patches go to https://gitlab.archlinux.org/archlinux/packaging/packages/lxdm/-/merge_requests/1.

I believe read -r is a good practice. Why not?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants