Conversation
Changed dropdown items from href-based navigation to onClick handlers with router.push() and window.open() to ensure proper functionality on mobile devices. Updated Etherscan links to use the correct network (chainName) instead of hardcoded 'mainnet'. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Deploying ens-app-v3 with
|
| Latest commit: |
90cc320
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b6ae900a.ens-app-v3.pages.dev |
| Branch Preview URL: | https://feature-fet-1981-profile-add.ens-app-v3.pages.dev |
Fixed 18 failing tests by adding necessary mocks for useRouterWithHistory and useChainName hooks that were introduced in the ProfileButton component changes. Changes: - Added useRouterWithHistory and useChainName mocks to ProfileButton.test.tsx - Added same mocks to ProfileDetails.test.tsx - Updated test assertions to check for button elements instead of anchor tags since dropdown items now use onClick handlers 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
…log-on-mobile-not-functioning
…log-on-mobile-not-functioning
…log-on-mobile-not-functioning
…log-on-mobile-not-functioning
Break long onClick handler lines in ProfileButton.tsx to satisfy prettier line length rules after merge conflict resolution. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
…log-on-mobile-not-functioning
…log-on-mobile-not-functioning
Replace hardcoded Etherscan references with dynamic block explorer URLs based on chain configuration. This allows the app to display correct block explorer links for different networks (mainnet, testnets, L2s). - Add useBlockExplorer hook with buildAddressUrl, buildTransactionUrl, and buildNftUrl utilities - Update ProfileButton, Token, ContractSection, RoleRow, RegistrationDate, and useExpiryDetails to use the new hook - Add viewOnBlockExplorer translation key - Add block explorer config to localhost chain
…log-on-mobile-not-functioning
Update tests to match component changes that now use the useBlockExplorer hook instead of usePublicClient. Change expected translation key from 'transaction.viewEtherscan' to 'transaction.viewOnBlockExplorer' to align with the new parameterized translation.
…le-not-functioning' of https://github.com/ensdomains/ens-app-v3 into feature/fet-1981-profile-address-dropdowndialog-on-mobile-not-functioning
…log-on-mobile-not-functioning
|
laurgk
approved these changes
Jan 26, 2026
laurgk
deleted the
feature/fet-1981-profile-address-dropdowndialog-on-mobile-not-functioning
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Went through the app looking for Etherscan links and found a bunch of links that do not change depending on whether the user is on a testnet or a mainnet. The following is a summary:
Component: ProfileButton.tsx (AddressProfileButton)
Location: Profile page → Records section → Click dropdown on ETH address
What to look for: "View on Etherscan" menu item
Component: ProfileButton.tsx (OwnerProfileButton)
Location: Profile page → Owner/Manager buttons → Click dropdown
What to look for: "View on Etherscan" menu item for address types
Component: RoleRow.tsx
Location: Profile page → Ownership tab → Roles section → Click ⋮ dropdown
What to look for: "View on Etherscan" menu item
Component: ContractSection.tsx
Location: Profile page → Ownership tab → Contract section (wrapped names only)
What to look for: NameWrapper address link
Component: Token.tsx
Location: Profile page → More tab → Token section
What to look for: "Etherscan" outlink in header (for 2LD .eth or wrapped names)
Component: RegistrationDate.tsx
Location: Profile page → More tab → Miscellaneous section