Merged
Conversation
The sync manager transaction was using proveAndClaimWithResolver when an address was provided, which attempts to set the resolver and address record. This caused reverts on already-imported DNS names. Now the address is stripped before calling importDnsName.makeFunctionData(), using the simpler proveAndClaim function that only updates ownership. Also added dnsRegistrarErrors to error decoding for better error messages. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
|
Deploying ens-app-v3 with
|
| Latest commit: |
cb8e313
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://46770f03.ens-app-v3.pages.dev |
| Branch Preview URL: | https://feature-fet-2624-current-man.ens-app-v3.pages.dev |
|
laurgk
approved these changes
Jan 7, 2026
laurgk
deleted the
feature/fet-2624-current-manager-app-sync-manager-on-onchain-dns-names
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sync manager transaction was using proveAndClaimWithResolver when an address was provided, which attempts to set the resolver and address record. This caused reverts on already-imported DNS names. Now the address is stripped before calling importDnsName.makeFunctionData(), using the simpler proveAndClaim function that only updates ownership.
Also added dnsRegistrarErrors to error decoding for better error messages.
🤖 Generated with Claude Code