Skip to content

Custom namewrapper aware resolvers block profile editor#914

Merged
LeonmanRolls merged 27 commits intomainfrom
fix-custom-resolver-namewrapper-aware-bug
Mar 6, 2025
Merged

Custom namewrapper aware resolvers block profile editor#914
LeonmanRolls merged 27 commits intomainfrom
fix-custom-resolver-namewrapper-aware-bug

Conversation

@storywithoutend
Copy link
Copy Markdown
Contributor

@storywithoutend storywithoutend commented Dec 2, 2024

  • Broke apart ResolverWarningOverlay to make navigation between different views more flexible.
  • useProfileEditorReducer
    • Manages navigating profile editor flows using push pop pattern
    • Includes a initialize function that sets the base view
  • For several views that relied on a callback to update a migration type value, the value was encapsulated inside the component and the value passed through the "next" button onClick callback.
  • There are now the following resolvers available in the e2e test env
    • Outdated resolver
    • Custom outdated resolver
    • Legacy resolver
    • Custom legacy resolver
    • Namewrapper aware resolver
    • Custom Namewrapper aware resolver
  • Bug fix in WrapButton
    • removed condition isNameWrapperAware in shouldMigrate because it causes false negatives for custom name wrapper aware resolvers.
  • Small bug fix in wrapName.spec.ts.
    • 'namewrapper-status' tag is not displayed when user can wrap name, but passes in CI because it appears on initial render.

@sonarqubecloud
Copy link
Copy Markdown

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages bot commented Feb 5, 2025

Deploying ens-app-v3 with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3356a23
Status: ✅  Deploy successful!
Preview URL: https://724e8ec1.ens-app-v3.pages.dev
Branch Preview URL: https://fix-custom-resolver-namewrap.ens-app-v3.pages.dev

View logs

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Mar 5, 2025

@LeonmanRolls LeonmanRolls merged commit c505e90 into main Mar 6, 2025
40 checks passed
@LeonmanRolls LeonmanRolls deleted the fix-custom-resolver-namewrapper-aware-bug branch March 6, 2025 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants