Skip to content

fixed a stateful test #995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
laurgk merged 1 commit into from
Apr 25, 2025
Merged

fixed a stateful test #995

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions e2e/specs/stateful/dnsclaim.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,7 @@ test.describe('Import DNSSEC name', () => {
await expect(page.getByTestId('import-next-button')).toBeDisabled()
})

// TODO: this is failing because stateful tests are still on goerli, we should switch to sepolia/holesky
test.skip('should not allow the user to proceed if they have not set the correct TXT record - offchain', async ({
test('should not allow the user to proceed if they have not set the correct TXT record - offchain', async ({
page,
login,
}) => {
Expand All @@ -43,10 +42,10 @@ test.describe('Import DNSSEC name', () => {
await page.getByTestId('import-next-button').click()
await expect(page.getByTestId('import-heading')).toContainText('Verify Ownership')
await expect(page.getByTestId('status-checker-message')).toContainText('No record found')
await expect(page.getByTestId('import-next-button')).toBeDisabled()
await expect(page.getByTestId('offchain-claim')).toBeDisabled()
})

test('should not allow the use to proceed if they have not set the correct subdomain with the correct info', async ({
test('should not allow the user to proceed if they have not set the correct subdomain with the correct info', async ({
page,
login,
}) => {
Expand All @@ -60,7 +59,8 @@ test.describe('Import DNSSEC name', () => {
await expect(page.getByTestId('import-next-button')).toBeDisabled()
})

test('should resolve .pw domains', async ({ page, login }) => {
test.skip('should resolve .pw domains', async ({ page, login }) => {
// pw domain does not resolve on localhost
await page.goto('/test.pw?chain=holesky')
await login.connect()

Expand Down
1 change: 1 addition & 0 deletions src/components/pages/import/[name]/steps/VerifyOffchainOwnership.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,7 @@ export const VerifyOffchainOwnership = ({
</DnsImportActionButton>
{isConnected ? (
<DnsImportActionButton
data-testid="offchain-claim"
disabled={!dnsOffchainStatus || isLoading || isRefetching || isError || !!error}
onClick={() => {
sendEvent('import:offchain_verify', { name: selected.name })
Expand Down
⚡