Skip to content

fix: metamask explicit transaction type#998

Merged
laurgk merged 2 commits intomainfrom
fix/metamask-transaction-type
Apr 30, 2025
Merged

fix: metamask explicit transaction type#998
laurgk merged 2 commits intomainfrom
fix/metamask-transaction-type

Conversation

@TateB
Copy link
Copy Markdown
Member

@TateB TateB commented Apr 29, 2025

adds explicit transaction type for MetaMask transactions to avoid this issue: MetaMask/core#5720

only added on MetaMask txs in case explicit type is an issue in any wallets

@TateB TateB requested review from laurgk and sugh01 as code owners April 29, 2025 05:01
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages bot commented Apr 29, 2025

Deploying ens-app-v3 with  Cloudflare Pages  Cloudflare Pages

Latest commit: f8e6352
Status: ✅  Deploy successful!
Preview URL: https://b06ad685.ens-app-v3.pages.dev
Branch Preview URL: https://fix-metamask-transaction-typ.ens-app-v3.pages.dev

View logs

@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

@laurgk laurgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested - looks good.

@laurgk laurgk merged commit 4366718 into main Apr 30, 2025
40 checks passed
@laurgk laurgk deleted the fix/metamask-transaction-type branch April 30, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants