Skip to content

api: pluralize recently added repeated field name#35284

Merged
adisuissa merged 1 commit into
envoyproxy:mainfrom
markdroth:orca_lrs_propagation
Jul 19, 2024
Merged

api: pluralize recently added repeated field name#35284
adisuissa merged 1 commit into
envoyproxy:mainfrom
markdroth:orca_lrs_propagation

Conversation

@markdroth

Copy link
Copy Markdown
Contributor

Commit Message: api: pluralize recently added repeated field name
Additional Description: Addresses a post-merge comment from #35210.
Risk Level: Low
Testing: N/A
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A

CC @wbpcode @efimki @AndresGuedez @ejona86 @dfawley @vishalpowar

Signed-off-by: Mark D. Roth <roth@google.com>
@repokitteh-read-only

Copy link
Copy Markdown

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @mattklein123
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

🐱

Caused by: #35284 was opened by markdroth.

see: more, trace.

@adisuissa adisuissa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm api

@adisuissa adisuissa enabled auto-merge (squash) July 19, 2024 15:35
@adisuissa adisuissa merged commit 799e3e2 into envoyproxy:main Jul 19, 2024
@markdroth markdroth deleted the orca_lrs_propagation branch September 18, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants