add KNX_IP_DISABLE_WEBSERVER and KNX_IP_DISABLE_EEPROM#74
Open
viknet365 wants to merge 6 commits intoenvy:masterfrom
Open
add KNX_IP_DISABLE_WEBSERVER and KNX_IP_DISABLE_EEPROM#74viknet365 wants to merge 6 commits intoenvy:masterfrom
viknet365 wants to merge 6 commits intoenvy:masterfrom
Conversation
add KNX_IP_DISABLE_EEPROM directive to disable the read/write of the eeprom
this directive is sed to completely disable the webserver specially if in used elsewhere
the KNX_IP_DISABLE_WEBSERVER is used to completely disable the webserver
add the KNX_IP_DISABLE_WEBSERVER to completely disable the webserver
spacegaier
reviewed
Apr 9, 2020
There was a problem hiding this comment.
@viknet365 Is there a reason why some #if guards are added inside the method body (which keeps the API stable independently of whether the #define is set or not) whereas for others are outside methods and therefore completely hide/remove them?
Author
|
Hello @spacegaier, there are probably better way to do it, but I tried to : remove unused functions when disabling eeprom or webserver and remove line they are beeing called (this way it was easier to spot issues at compilation). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
these two directive are usefull in environement where eeprom and webserver are managed by others