Skip to content

ESP32 Quickfix#85

Open
c-o-m-m-a-n-d-e-r wants to merge 1 commit intoenvy:masterfrom
c-o-m-m-a-n-d-e-r:master
Open

ESP32 Quickfix#85
c-o-m-m-a-n-d-e-r wants to merge 1 commit intoenvy:masterfrom
c-o-m-m-a-n-d-e-r:master

Conversation

@c-o-m-m-a-n-d-e-r
Copy link
Copy Markdown

quick try to implement ESP32

quick try to implement ESP32
@wladwnt
Copy link
Copy Markdown

wladwnt commented Sep 9, 2021

Good Fox for ESP32, but this part change not needed (is wrong):

#ifdef ESP32
    long m = pow(round(v), 0x7FF);
#else
    long m = round(v) & 0x7FF;
#endif

@c-o-m-m-a-n-d-e-r
Copy link
Copy Markdown
Author

Why? :-)

@wladwnt
Copy link
Copy Markdown

wladwnt commented Sep 10, 2021

Because round(v) & 0x7f gives correct result on ESP32, checked via ETS5. Why the calculation on ESP32 should be different to ESP8266?

@c-o-m-m-a-n-d-e-r
Copy link
Copy Markdown
Author

haha oh man ... you are right, sorry was writing from the autobahn ... ignore that please 🤣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants