Epicshop workshop review#21
Merged
kentcdodds merged 3 commits intomainfrom Jan 16, 2026
Merged
Conversation
- Document learning outcomes for all 10 exercises (1.1-1.2, 2.1, 3.1-3.2, 4.1-4.2, 5.1-5.3) - Identify recurring mimeType test issue affecting exercises 3.1 onwards - Provide overall workshop feedback with positive aspects and improvements Co-authored-by: me <me@kentcdodds.com>
|
Cursor Agent can help with this pull request. Just |
…iple exercises. Update error messages to clarify JSON structure requirements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a learning review for the Advanced MCP Features workshop.
The review documents the completion of all workshop exercises and provides feedback on learning outcomes, instructional clarity, cognitive load, examples, and mechanical correctness. A recurring issue was identified where problem test files incorrectly expected
mimeType: 'application/json'in sampling content, despite the SDK stripping this field and solution tests omitting this check, leading to unnecessary test failures.Note
Aligns sampling tests with SDK behavior (no
mimeTypeon text content) and simplifies JSON validation.mimeTypeexpectations and invariants fromsampling/createMessagerequests in advanced, long-running tasks, and changes exercises{ content: { text: string } }and parse JSON fromcontent.texttextinstead of requiringmimeType: "application/json"mimeTypein error paths; keep checks formaxTokens,systemPrompt, and JSON structureWritten by Cursor Bugbot for commit 279c882. This will update automatically on new commits. Configure here.