feat: vdf sparse horizon handler - file writing and reading#278
Merged
Conversation
added 5 commits
November 12, 2024 23:27
Collaborator
Author
|
Update: now using org.matsim.utils.eventsfilecomparison.EventsFileComparator to compare the event files resulting from using the VDFHorizonHandler VS the VDFSparseHorizonHandler. The test pass now. |
Collaborator
|
Great, good to merge? |
Collaborator
Author
Yes |
sebhoerl
added a commit
that referenced
this pull request
Nov 26, 2024
* feat: sparse horizon handler for vdf * small fix * feat: vdf sparse horizon handler - file writing and reading (#278) * feat: Using VDFSparseHorizonHandler by default * fix: file writing and reading * feat: towards testing VDFSparseHorizonHandler VS VDFHorizonHandler * chore: cleanup * feat: comparing output events of VDFHorizonHandler and VDFSparseHorizonHandler --------- Co-authored-by: tkchouaki <tarek.chouaki@irt-systemx.fr> * chore: comparing plans instead of events --------- Co-authored-by: Tarek Chouaki <tkchouaki@gmail.com> Co-authored-by: tkchouaki <tarek.chouaki@irt-systemx.fr>
And128
pushed a commit
to And128/eqasim-java
that referenced
this pull request
Oct 10, 2025
* feat: sparse horizon handler for vdf * small fix * feat: vdf sparse horizon handler - file writing and reading (eqasim-org#278) * feat: Using VDFSparseHorizonHandler by default * fix: file writing and reading * feat: towards testing VDFSparseHorizonHandler VS VDFHorizonHandler * chore: cleanup * feat: comparing output events of VDFHorizonHandler and VDFSparseHorizonHandler --------- Co-authored-by: tkchouaki <tarek.chouaki@irt-systemx.fr> * chore: comparing plans instead of events --------- Co-authored-by: Tarek Chouaki <tkchouaki@gmail.com> Co-authored-by: tkchouaki <tarek.chouaki@irt-systemx.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the reading and writing of the vdf.bin file in the VDFSparseHorizonHandler currently under implementation (see PR #276).
The writing and reading are tested in TestSimulationPipeline::runVdf by first running a VDF simulation using the VDFSparseHorizonHandler and then running a standalone mode choice on the same config while passing the written vdf.bin.
Moreover, this PR prepares the comparison of simulation outputs with the VDFSparseHorizonHandler and the old VDFHorizonHandler by comparing the output events. This test is not passing currently, line 404 should be un-commented to check before merging into the develop branch.